Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres variant logos #114

Merged
merged 13 commits into from
Mar 5, 2024
Merged

Postgres variant logos #114

merged 13 commits into from
Mar 5, 2024

Conversation

plcplc
Copy link
Contributor

@plcplc plcplc commented Mar 4, 2024

This PR adds ndc-hub entries to the following Postgres (and variants) offerings:

  • AWS Aurora
  • Citus
  • CockroachDB
  • Neon
  • Google Spanner
  • YugabyteDB

"version": [
{
"tag": "v0.2.0",
"hash": "98801634b0e1396c933188eef88178952f412a8c",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should wait a bit until we release v0.4.0, and then bump the tag and the hash for all connectors (including postgres)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we might as well merge this PR now. It'll be the same amount of work to update the hashes regardless, and at least with this PR the new logos will show up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.4 has been released :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is now updated to refer to v0.4.0~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see v0.2.0 here and in other places (latest_version). could you please find and replace 0.2.0 to 0.4.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the hash seems to be different in a few entries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I had forgotten the aurora connector!

I've also updated the overview.latest_version from v0.2.0 to v0.4.0.

@TheInnerLight
Copy link

TheInnerLight commented Mar 4, 2024

Should we add a list of items to the READMEs to show which databases are supported? e.g.

Supported Variants

  • Vanilla Postgres
  • AWS Aurora
  • Citus
  • CockroachDB
  • Neon
  • Google Spanner
  • YugabyteDB

(I'm not sure if this is the right flavour of markdown?)

@plcplc
Copy link
Contributor Author

plcplc commented Mar 4, 2024

Should we add a list of items to the READMEs to show which databases are supported?

I think it would definitely be appropriate to update the top-level README.md, perhaps just having it reference the registry folder rather than essentially listing it in prose.

@plcplc plcplc requested a review from soupi March 5, 2024 11:57
registry/aurora/README.md Outdated Show resolved Hide resolved
registry/citus/README.md Outdated Show resolved Hide resolved
registry/cockroach/README.md Outdated Show resolved Hide resolved
registry/neon/README.md Outdated Show resolved Hide resolved
registry/spanner/README.md Outdated Show resolved Hide resolved
registry/yugabyte/README.md Outdated Show resolved Hide resolved
@plcplc plcplc requested a review from soupi March 5, 2024 13:06
Copy link
Contributor

@soupi soupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plcplc plcplc merged commit 4cb500e into main Mar 5, 2024
5 checks passed
@SamirTalwar SamirTalwar deleted the plc/postgres-variants branch March 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants