-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres variant logos #114
Conversation
registry/aurora/metadata.json
Outdated
"version": [ | ||
{ | ||
"tag": "v0.2.0", | ||
"hash": "98801634b0e1396c933188eef88178952f412a8c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should wait a bit until we release v0.4.0, and then bump the tag and the hash for all connectors (including postgres)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we might as well merge this PR now. It'll be the same amount of work to update the hashes regardless, and at least with this PR the new logos will show up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.4 has been released :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is now updated to refer to v0.4.0~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see v0.2.0 here and in other places (latest_version). could you please find and replace 0.2.0 to 0.4.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the hash seems to be different in a few entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. I had forgotten the aurora connector!
I've also updated the overview.latest_version
from v0.2.0
to v0.4.0
.
Should we add a list of items to the READMEs to show which databases are supported? e.g. Supported Variants
(I'm not sure if this is the right flavour of markdown?) |
I think it would definitely be appropriate to update the top-level README.md, perhaps just having it reference the registry folder rather than essentially listing it in prose. |
Co-authored-by: Gil Mizrahi <[email protected]>
Co-authored-by: Gil Mizrahi <[email protected]>
Co-authored-by: Gil Mizrahi <[email protected]>
Co-authored-by: Gil Mizrahi <[email protected]>
Co-authored-by: Gil Mizrahi <[email protected]>
Co-authored-by: Gil Mizrahi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds ndc-hub entries to the following Postgres (and variants) offerings: